Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement throttling for WS client #158

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Dec 9, 2024

The configurations already exist due to reusing ffresty config initialisation logic.

This PR implements the throttling logic itself

Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - a few questions

pkg/fftypes/uuid.go Show resolved Hide resolved
pkg/ffresty/ffresty.go Show resolved Hide resolved
pkg/ffresty/ffresty.go Show resolved Hide resolved
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@EnriqueL8 EnriqueL8 merged commit 7079e15 into hyperledger:main Dec 18, 2024
3 checks passed
@EnriqueL8 EnriqueL8 deleted the ws-throttling branch December 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants