Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ModifyQuery" to CRUD interface for arbitrary SQL processing #106

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

awrichar
Copy link
Contributor

While ReadQueryModifier allows CRUD models to have static additions (for joins or complex filtering), this will allow for more dynamic additions to any query.

While ReadQueryModifier allows CRUD models to have static additions
(for joins or complex filtering), this will allow for more dynamic
additions to any query.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

We're currently processing your upload. This comment will be updated when the results are available.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

As we've discussed, a wider step back and look at a "V2" of the interface that reconciles the options a bit, would be a great thing at some point.

But this feels perfectly in-ilne with the additive nature of function we've done so far

@peterbroadhurst peterbroadhurst merged commit 090eeb5 into hyperledger:main Nov 9, 2023
2 checks passed
@peterbroadhurst peterbroadhurst deleted the modify-query branch November 9, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants