Add an option '--remote-node-deploy' to treat remote nodes like local nodes #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew1001
requested review from
nguyer,
awrichar and
peterbroadhurst
as code owners
… nodes Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
matthew1001
force-pushed
the
remote-node-deploy
branch
from
65d36b1 to
89d21df
Compare
nguyer
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this option allows the
ff initcommand to be run with-n remote-rpcwithout specifying--contract-address, something which was previously not supported.By default the CLI will behave the same as previous versions. However, setting the new
--remote-node-deploy=trueoption will perform both the deployment of the FireFly contract, and the identity/org registration. Effectively this option is a way of saying "the remote node is a free-gas chain", but I thought it might be possible to use for non-free-gas chains such as Polygon, if you had a way of ensuring your signing key had enough gas to pay for the deployment. Hence calling the new option--remote-node-deploy, not--remote-node-free-gasor similar.