-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for evmconnect #199
Conversation
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
…ng startup Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Just a note that this PR contains a fix for a timing issue, to do with the IPFS container being terminated during the The fix was to add a healthcheck to the IPFS container, and then a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Like the change to passing the context included in this, and the neat way you've done the refactor around making the connector selectable.
I note the |
…evmconnect Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
This PR adds support for evmconnect and chosing between it and ethconnect (still the default) with the new
-c, --blockchain-connector
flag.It also moves logging related items to a context which is passed throughout the CLI code, and it creates a new interface for blockchain connectors.
Right now a BlockchainProvider creates the blockchain connector instance, but I feel like it should probably be the other way around in the future. That's a refactor for another day, as it is quite a disruptive code change, with no tangible benefit to the end user (only code maintainability).