SPI updates for new alpha #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
approved these changes
Jun 9, 2022
| @@ -33,7 +33,7 @@ import ( | |||
| "github.com/hyperledger/firefly-cli/pkg/types" | |||
| ) | |||
|
|
|||
| var ethsignerImage = "ghcr.io/hyperledger/firefly-signer:v0.9.1" | |||
| var ethsignerImage = "ghcr.io/hyperledger/firefly-signer:v0.9.6" | |||
There was a problem hiding this comment.
Just noting that there is an ongoing conversation about what the "right" place for these is, and calling out that we're all in agreement it's not here. But it's here for now until we find a better spot for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spiconfig section for the new SPI, which supersedes the Admin APIadminconfig section is not removed, as the FireFly CLI needs to generate config that works for the V1.0.x stream still, and without this section the admin API would be turned off in V1.0.xWith this the instructions in https://gist.github.com/peterbroadhurst/63b147c679f76d485523650e76796009 can be executed successfully (instructions updated to use the
alphachannel, rather than source builds).