Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow client TLS certificate and key to be specified in connection profile #261

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Allow client TLS certificate and key to be specified in connection profile #261

merged 2 commits into from
Feb 13, 2023

Conversation

irririki
Copy link
Contributor

@irririki irririki commented Feb 8, 2023 •
edited by bestbeforetoday
Loading

I have done the changes as follows:

  1. change property names from tlsClient* to client* in NetworkConfig.java; add unit test and associated fixture.
  2. change from tlsClient* to client* in HFCAClient.java; add unit test and associated fixtures.
  3. Refactor clientCert* and clientKey* to constant in Endpoint.java and apply the constants in Channel.java.

Closes #260

@irririki irririki requested a review from a team as a code owner February 8, 2023 02:19
change property names from tlsClient* to client*; add unit test and f…
27898b4 
…ixture;Refactor clientCert* and clientKey* to constant.

Signed-off-by: Sheng Guo <sheng.guo@socialmapconsulting.com>
bestbeforetoday
bestbeforetoday requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Just some minor changes I think would be worth making - see review comments for specific lines.

move client cert and key constants from Endpoint to NetworkConfig; Re…
440b155 
…move tlsClient* test cases; Replace all the client* strings with the constancts

Signed-off-by: Sheng Guo <sheng.guo@socialmapconsulting.com>
@bestbeforetoday bestbeforetoday merged commit 678746b into hyperledger:main Feb 13, 2023
@bestbeforetoday
Copy link
Member

@Mergifyio backport release-2.2

mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@irririki @mergify
Allow client TLS certificate and key to be specified in connection pr…
d4cac19 
…ofile (#261)

Signed-off-by: Sheng Guo <sheng.guo@socialmapconsulting.com>
(cherry picked from commit 678746b)
@mergify mergify bot mentioned this pull request Feb 13, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

backport release-2.2

✅ Backports have been created

@bestbeforetoday bestbeforetoday changed the title release-2.2 mutual tls config key and peer property key not matching #260 Allow client TLS certificate and key to be specified in connection profile Feb 13, 2023
bestbeforetoday pushed a commit that referenced this pull request Feb 13, 2023
@irririki @bestbeforetoday
Allow client TLS certificate and key to be specified in connection pr…
7fac5e4 
…ofile (#261)

Signed-off-by: Sheng Guo <sheng.guo@socialmapconsulting.com>
(cherry picked from commit 678746b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release-2.2 mutual tls config key and peer property key not matching
2 participants
@irririki @bestbeforetoday