Include error details in unchecked Java exception #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checked GatewayException already has its printStackTrace augmented with any associated gRPC ErrorDetail elements. The same functionality is added to the equivalent unchecked GatewayRuntimeException. The two exceptions are intended to behave identically, with the unchecked variant to be used only where a checked exception cannot be thrown due to the standard APIs exposed. For example, the Iterator methods used when retrieving events. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
andrew-coleman
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checked GatewayException already has its printStackTrace augmented with any associated gRPC ErrorDetail elements. The same functionality is added to the equivalent unchecked GatewayRuntimeException. The two exceptions are intended to behave identically, with the unchecked variant to be used only where a checked exception cannot be thrown due to the standard APIs exposed. For example, the Iterator methods used when retrieving events.