[FAB-13051] npm audit checks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbwhite
requested review from
awjh-ibm,
davidkel and
zhaochy1990
as code owners
mbwhite
force-pushed
the
npm-audit-checks
branch
4 times, most recently
from
a63fea4 to
015d7d7
Compare
As rush and pnpm are used, implement the npm audit by instally the built artifacts to a fake directory with npm and then running npm audit Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Change-Id: I9a621b8653a4dbcdd41c056398f21db173447f9f
mbwhite
force-pushed
the
npm-audit-checks
branch
from
015d7d7 to
5c79352
Compare
awjh-ibm
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rush and pnpm are used, implement the npm audit
by instally the built artifacts to a fake directory with npm
and then running npm audit
Signed-off-by: Matthew B White whitemat@uk.ibm.com
Change-Id: I9a621b8653a4dbcdd41c056398f21db173447f9f