Update to use Node 12.16.1 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbwhite
force-pushed
the
node12
branch
3 times, most recently
from
d98306d to
08d5e47
Compare
heatherlp
suggested changes
Apr 2, 2020
COMPATIBILITY.md
Outdated
| @@ -12,7 +12,7 @@ This table shows the summary of the compatibility of the Node modules at version | |||
| | Node modules **v1.4** | Yes | 8 | Yes | | |||
| | Node modules **v2.x** | Yes | 10 | Yes | | |||
There was a problem hiding this comment.
this table will need an update
TUTORIAL.md
Outdated
| @@ -15,7 +15,7 @@ The dependencies of `fabric-chaincode-api` and `fabric-shim` will be required. | |||
| "name": "chaincode", | |||
| "description": "My first exciting chaincode implemented in node.js", | |||
| "engines": { | |||
| "node": "^10.15.2", | |||
| "node": "^12.15.0", | |||
There was a problem hiding this comment.
I think this should be ^12.16.1" ?
Set node engine to be the latest LTS at time of commit 12.6.1 Due to issues with comibation of the 12.6 and rewire, unit tests are run with node 12.5.0 Updated timeout as Typescript compilation seems to have slowed down. Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
awjh-ibm
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthew B White whitemat@uk.ibm.com