Op guide fixes #204
Merged
Op guide fixes #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a command that enrolled the Org0's Admin with wrong credentials and eventually failed to do that because of mismatch with registration credentials. Signed-off-by: Mattia Righetti <matt95.righetti@gmail.com>
Fixes missing TLS environmental variable in complete docker-compose.yml concerning operation guide. Not inserting that env will cause a communication error if components contact the TLS CA through HTTPS as described in the operation guide. Signed-off-by: Mattia Righetti <matt95.righetti@gmail.com>
mattrighetti
force-pushed
the
op-guide-fixes
branch
from
4594b02 to
d4f4442
Compare
mastersingh24
approved these changes
Dec 12, 2020
|
Thanks @mattrighetti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
I've been following the operation guide and I've noticed two errors that I've fixed in this PR:
FABRIC_CA_SERVER_TLS_ENABLED=trueis not present in the completedocker-compose.ymlfile referenced at the beginning of the guide but it is only present in the Setup TLS CA sectionhttps://orderer-org0-admin:ordererAdminPW@0.0.0.0:7053) are different from the registration ones (... --id.name admin-org0 --id.secret org0adminpw ...) hence the program can't enrol the admin successfullyThe PR includes fixes for the issues listed above
Quick Links:
Docker-compose.yml reference file
Org0's Admin Enrolment