Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated registrar users #159

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated registrar users #159

merged 1 commit into from
Jun 24, 2020

Conversation

caod123
Copy link

@caod123 caod123 commented May 20, 2020

Type of change

  • New feature

Description

Since the initial release of Fabric CA, the list of reserved attributes (hf.*) has grown. A certain subset of users upon migration from an older version of CA to a newer one should be given any newly introduced attributes that have been added in the new release.

Related issues

FABC-829

@caod123 caod123 requested a review from a team as a code owner May 20, 2020 15:14
@caod123
Copy link
Author

caod123 commented May 20, 2020

Questions for consideration:

  1. This change only adds the the attributes to any registrar users. Is that enough or should they be added to all migrated users?
  2. This change only adds the two attributes hf.AffiliationMgr and hf.GenCRL at request of the original JIRA issue. Is there a need to also add logic for the remaining attributes in https://github.com/hyperledger/fabric-ca/blob/master/lib/attr/attribute.go#L41-L50

@caod123
Copy link
Author

caod123 commented May 20, 2020

  1. This change only adds the the attributes to any registrar users. Is that enough or should they be added to all migrated users?

I misunderstood how the attributes are added. I believe all users will need to have these attributes so they can be registered by the registrar.

@caod123 caod123 changed the title [FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated registrar users [FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated users May 20, 2020
@mastersingh24
Copy link
Contributor

  1. This change only adds the the attributes to any registrar users. Is that enough or should they be added to all migrated users?

These should only be added to registrars as you can only register users if you have that role.

  1. This change only adds the two attributes hf.AffiliationMgr and hf.GenCRL at request of the original JIRA issue. Is there a need to also add logic for the remaining attributes in https://github.com/hyperledger/fabric-ca/blob/master/lib/attr/attribute.go#L41-L50

As best as I can tell, I believe these might be the only roles added since the initial release

mastersingh24
mastersingh24 suggested changes May 24, 2020
View reviewed changes
lib/server/user/user.go Outdated Show resolved Hide resolved
lib/server/user/user.go Outdated Show resolved Hide resolved
@caod123
[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated
25aee7b 
registrar users

Signed-off-by: Danny Cao <dcao@us.ibm.com>
@caod123
Copy link
Author

caod123 commented May 26, 2020

Makes sense, guess I had it right the first time and misunderstood.

@caod123 caod123 changed the title [FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated users [FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated registrar users May 26, 2020
@caod123 caod123 requested a review from mastersingh24 May 28, 2020 17:37
@caod123
Copy link
Author

caod123 commented Jun 1, 2020

Reminder we'll need to backport this after it's merged.

@caod123
Copy link
Author

caod123 commented Jun 3, 2020

@mastersingh24 are you ready to merge this?

@mastersingh24 mastersingh24 merged commit 5180751 into hyperledger:master Jun 24, 2020
@mastersingh24
Copy link
Contributor

@caod123 - are you planning to backport this one?

@caod123
Copy link
Author

caod123 commented Jun 24, 2020

@Mergifyio backport release-1.4

@mergify
Copy link

mergify bot commented Jun 24, 2020

@caod123 is not allowed to run commands

@lindluni
Copy link
Contributor

@Mergifyio backport release-1.4

mergify bot pushed a commit that referenced this pull request Jun 24, 2020
@caod123
[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated (…
ad353d6 
…#159)

registrar users

Signed-off-by: Danny Cao <dcao@us.ibm.com>
(cherry picked from commit 5180751)
@mergify mergify bot mentioned this pull request Jun 24, 2020
Merged
@mergify
Copy link

mergify bot commented Jun 24, 2020

Command backport release-1.4: success

Backports have been created

mastersingh24 pushed a commit that referenced this pull request Jun 24, 2020
@caod123 @mastersingh24
[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated (…
fcda8bb 
…#159)

registrar users

Signed-off-by: Danny Cao <dcao@us.ibm.com>
(cherry picked from commit 5180751)
guijunchen pushed a commit to guijunchen/fabric-ca that referenced this pull request Feb 26, 2021
@caod123
[FABC-829] Add hf.AffiliationMgr and hf.GenCRL attributes to migrated (…
6ccdb44 
…hyperledger#159)

registrar users

Signed-off-by: Danny Cao <dcao@us.ibm.com>
(cherry picked from commit 5180751)
Signed-off-by: 陈桂军 <chengj16@bngrp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastersingh24 mastersingh24 mastersingh24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caod123 @mastersingh24 @lindluni