Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the approve form. #578

Merged
merged 3 commits into from
Nov 18, 2023
Merged

Added the approve form. #578

merged 3 commits into from
Nov 18, 2023

Conversation

xiaor2
Copy link
Member

@xiaor2 xiaor2 commented Nov 3, 2023

  1. Added the approve form.
  2. Checked the code style.

@xiaor2
Added the approve form.
9208470 
Signed-off-by: Xiao Ran <shawnran182@gmail.com>
@xiaor2 xiaor2 requested a review from a team November 3, 2023 18:16
@xichen1 xichen1 removed their assignment Nov 4, 2023
xichen1
xichen1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@xichen1 xichen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update msg id

src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
src/dashboard/src/pages/ChainCode/forms/ApproveForm.js Outdated Show resolved Hide resolved
@xiaor2
Changed the message ids.
07f30bb 
Signed-off-by: Xiao Ran <shawnran182@gmail.com>
xichen1
xichen1 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@xichen1 xichen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yeasy yeasy merged commit 5deac2f into hyperledger:main Nov 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xichen1 xichen1 xichen1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaor2 @xichen1 @yeasy