Implement Chaincode dashboard #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement chaincode dashboard. Add the required buttons to the page. Use the dummy data for the dev purposes, will delete after all features are finished. Signed-off-by: xichen1 <xichen.pan@gmail.com>
Signed-off-by: xichen1 <xichen.pan@gmail.com>
fengyangsy
reviewed
Oct 21, 2023
fengyangsy
reviewed
Oct 21, 2023
| onOk={onSubmit} | ||
| onCancel={() => handleModalVisible(false)} | ||
| > | ||
| <Form onFinish={onFinish} form={form} preserve={false}> | ||
| <FormItem | ||
| {...formItemLayout} | ||
| label={intl.formatMessage({ | ||
| id: 'app.chainCode.form.create.name', | ||
| defaultMessage: 'Name', | ||
| id: 'app.operator.chainCode.form.create.file', |
There was a problem hiding this comment.
Can't find "app.operator.chainCode.form.create.file" in locales.
There was a problem hiding this comment.
it has been updated in b2493fd
fengyangsy
reviewed
Oct 21, 2023
| @@ -335,14 +335,14 @@ class ChainCode extends PureComponent { | |||
| <Divider type="vertical" /> | |||
| <a> | |||
| {intl.formatMessage({ | |||
| id: 'app.operator.chainCode.table.operate.approve', | |||
| id: 'app.chainCode.table.operate.approve', | |||
There was a problem hiding this comment.
Can't find "app.chainCode.table.operate.approve" in locales
There was a problem hiding this comment.
it's added in #572, which may need to be reviewed and merged first.
I created two pr to make the purpose of each task more clear.
fengyangsy
reviewed
Oct 21, 2023
| defaultMessage: 'Approve', | ||
| })} | ||
| </a> | ||
| <Divider type="vertical" /> | ||
| <a> | ||
| {intl.formatMessage({ | ||
| id: 'app.operator.chainCode.table.operate.commit', | ||
| id: 'app.chainCode.table.operate.commit', |
There was a problem hiding this comment.
Can't find "app.chainCode.table.operate.commit" in locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement chaincode dashboard. Add the required buttons to the page.
Use the dummy data for the dev purposes, will be deleted after all
features are finished.
Should be merged after #572 is merged.
Signed-off-by: xichen1 xichen.pan@gmail.com