Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-server): shutdown hook configuration is using wrong config key #1619

Closed
m-courtin opened this issue Dec 2, 2021 · 3 comments · Fixed by #1621
Closed

fix(api-server): shutdown hook configuration is using wrong config key #1619

m-courtin opened this issue Dec 2, 2021 · 3 comments · Fixed by #1621
Assignees
@m-courtin
Labels
API_Server bug Something isn't working dependent

Comments

@m-courtin
Copy link
Contributor

m-courtin commented Dec 2, 2021 •
edited
Loading

Describe the bug

In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken.

Depends on #1649
@m-courtin m-courtin added the bug Something isn't working label Dec 2, 2021
@m-courtin
Copy link
Contributor Author

@petermetz: Can you please assign this issue onto my name as discussed yesterday

m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 3, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
b1e2dcd 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
@m-courtin m-courtin mentioned this issue Dec 3, 2021
Merged
@petermetz
Copy link
Contributor

@m-courtin You got it, thank you for reporting!

m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 8, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
9058b20 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 10, 2021
@m-courtin
fix: add Unit Tests for Api-Server configuration testing
8b06f66 
Unit tests for testing default config behaviour + user-defined
configuration for shutdown hook

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 10, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
4ec7fcf 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 10, 2021
@m-courtin
fix: add Unit Tests for Api-Server configuration testing
6a05bca 
Unit tests for testing default config behaviour + user-defined
configuration for shutdown hook

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 10, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
16d1630 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

⏳ Alright! Looks like we need to wait for some dependencies:

💡 Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 15, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
7d639a1 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 15, 2021
@m-courtin
fix: set apiServerOptions.configFile=""
00c61c0 
Need to set apiServerOptions.configFile to empty string as otherwise the
build pipeline is failing

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 15, 2021
@m-courtin
fix: shutdown hook configuration is using wrong config key
52bcb04 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 15, 2021
@m-courtin
fix: set apiServerOptions.configFile=""
edc463c 
Need to set apiServerOptions.configFile to empty string as otherwise the
build pipeline is failing

Closes: hyperledger-cacti#1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
petermetz pushed a commit that referenced this issue Dec 15, 2021
@m-courtin @petermetz
fix: shutdown hook configuration is using wrong config key
e760e04 
In the api-server constructor the evaluation for the activation /
deactivation of the shutdown hook is based on the wrong configuration
property so that it always is falling back to the default value and
pre-configured value is not taken.

Closes: #1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
petermetz pushed a commit that referenced this issue Dec 15, 2021
@m-courtin @petermetz
fix: set apiServerOptions.configFile=""
5c5a1e1 
Need to set apiServerOptions.configFile to empty string as otherwise the
build pipeline is failing

Closes: #1619
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-courtin m-courtin

Labels
API_Server bug Something isn't working dependent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: shutdown hook configuration is using wrong config key m-courtin/cactus
2 participants
@petermetz @m-courtin