Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EOF to the Osaka Fork #7719

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Move EOF to the Osaka Fork #7719

merged 8 commits into from
Oct 10, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Oct 2, 2024

PR description

  • Ensure Osaka activations are working
  • Remove PragueEOF fork
  • Move EOF tools to default to Osaka

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@shemnon shemnon force-pushed the eof/osaka branch 2 times, most recently from dbc1e2f to 830b030 Compare October 3, 2024 21:23
* Ensure Osaka activations are working
* Remove CancunEOF and PragueEOF forks
* Move EOF tools to default to Osaka

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
* Make PC in trace zeroed to start of code section 0
* Update extcall to consider precompiles warm
* Add stack checking to CALLF operation

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon marked this pull request as ready for review October 10, 2024 03:42
Signed-off-by: Danno Ferrin <danno@numisight.com>
@@ -30,6 +31,9 @@ public class CallFOperation extends AbstractOperation {
/** The Call F success. */
static final OperationResult callfSuccess = new OperationResult(5, null);

static final OperationResult callfStackOverflow =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unrelated to the move to Osaka, is it intended to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for this test that's landing soon - ethereum/execution-spec-tests#889

Signed-off-by: Danno Ferrin <danno@numisight.com>
@macfarla macfarla merged commit efb6906 into hyperledger:main Oct 10, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants