Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tx validation if sender has delegated it's code via 7702 transaction #7593

Merged

Conversation

daniellehrner
Copy link
Contributor

@daniellehrner daniellehrner commented Sep 10, 2024

PR description

Transactions from account with delegated code are currently not validated correctly. This PR makes sure that those accounts can send tx, as specified in EIP-7702.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner requested review from shemnon and fab-10 and removed request for shemnon September 10, 2024 09:00
@daniellehrner daniellehrner changed the title fix 7702 tx validation in tx pool Fix tx validation if sender has delegated it's code via 7702 transaction Sep 10, 2024
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not blocking and could be deferred to another PR, the addition of some unit tests

@daniellehrner daniellehrner merged commit 01fcc7f into hyperledger:main Sep 10, 2024
40 checks passed
@daniellehrner daniellehrner deleted the fix/7702-tx-pool-validation branch September 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants