Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container security scanning #7216

Merged

Conversation

cdivitotawela
Copy link
Contributor

PR description

Container security scanning workflow added. This runs on schedule everyday. Also possible to run on-demand for a given image tag. This replace the CircleCI job running container scan daily. Schedule job only runs for the tag develop.

Fixed Issue(s)

fixes #7154

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

cdivitotawela and others added 4 commits June 13, 2024 10:00
Container security scanning workflow added. This runs on schedule everyday. Also possible to run on-demand for a given image tag

Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joshuafernandes joshuafernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor

should this PR also remove the CI job, or will we do that as a separate task @cdivitotawela (if the latter we should not close the issue with this PR)

@jflo
Copy link
Contributor

jflo commented Jun 13, 2024

fixes #3927 and #7126

@cdivitotawela cdivitotawela merged commit 884834f into hyperledger:main Jun 13, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA workflow for dockerscan
5 participants