Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sorting updated storage entries in commit phase #7167

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Jun 3, 2024

PR description

Remove sorting updated storage entries in commit phase as it has some overhead. Sorting the entries is not needed anymore.

Before this PR
image

With this PR
image

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@matkt matkt enabled auto-merge (squash) June 5, 2024 16:05
@matkt matkt merged commit 4fa2592 into hyperledger:main Jun 5, 2024
39 checks passed
gtebrean pushed a commit to gtebrean/besu that referenced this pull request Jun 26, 2024
)

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: George Tebrean <george@web3labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants