Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github arm64 runners #7054

Merged
merged 3 commits into from
May 10, 2024
Merged

Use github arm64 runners #7054

merged 3 commits into from
May 10, 2024

Conversation

seanyoung
Copy link
Contributor

github now offer arm64 runners.

The arm64 image is a plain ubuntu 22.04 server with nothing installed (no docker).

Fixes #7026

@seanyoung
Use github arm64 runners
5235f85 
Signed-off-by: Sean Young <sean@mess.org>
@ryjones ryjones requested a review from jflo May 6, 2024 13:57
siladu

This comment was marked as outdated.

Sign in to view

@siladu siladu dismissed their stale review May 7, 2024 02:45

this won't impact the release branch actually

siladu
siladu approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @seanyoung. Were you able to test the docker changes?

I am trying to test that at least the docker install works, but it's stuck waiting, not sure if that's expected...it did trigger with the correct runner, but maybe it's stuck because it's on my fork siladu/besu/actions/runs/8978675974/job/24659493468

@seanyoung
Copy link
Contributor Author

seanyoung commented May 7, 2024 •
edited
Loading

Thanks for the PR @seanyoung. Were you able to test the docker changes?

I haven't tested it, I was hoping CI would do that for me.

I am trying to test that at least the docker install works, but it's stuck waiting, not sure if that's expected...it did trigger with the correct runner, but maybe it's stuck because it's on my fork siladu/besu/actions/runs/8978675974/job/24659493468

Only github repos/organizations signed up to the private beta will have them available, so it won't work on your fork.

Is there a way we can test this in hyperledger/besu?

@siladu siladu enabled auto-merge (squash) May 10, 2024 01:57
@siladu
Copy link
Contributor

siladu commented May 10, 2024

Thanks for the PR @seanyoung. Were you able to test the docker changes?

I haven't tested it, I was hoping CI would do that for me.

I am trying to test that at least the docker install works, but it's stuck waiting, not sure if that's expected...it did trigger with the correct runner, but maybe it's stuck because it's on my fork siladu/besu/actions/runs/8978675974/job/24659493468

Only github repos/organizations signed up to the private beta will have them available, so it won't work on your fork.

Is there a way we can test this in hyperledger/besu?

@seanyoung Short of creating your own personal runner for this PR to point to, I can't think of one. Will merge and revert if it doesn't work. Not a big deal if we miss some intermediate commits on the develop tag.

@siladu siladu merged commit 2a39f2c into hyperledger:main May 10, 2024
42 checks passed
@siladu
Copy link
Contributor

siladu commented May 10, 2024

@seanyoung It did indeed fail: https://github.com/hyperledger/besu/actions/runs/9026355992/job/24803532413

siladu added a commit to siladu/besu that referenced this pull request May 10, 2024
@siladu
Revert "Use github arm64 runners (hyperledger#7054)"
2681e67 
This reverts commit 2a39f2c.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu
Copy link
Contributor

siladu commented May 10, 2024

PR to revert: #7087

siladu added a commit that referenced this pull request May 10, 2024
@siladu
Revert "Use github arm64 runners (#7054)" (#7087)
2db3705 
This reverts commit 2a39f2c.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
@seanyoung @siladu @jflo
Use github arm64 runners (hyperledger#7054)
7c7d8f1 
Signed-off-by: Sean Young <sean@mess.org>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
@siladu @jflo
Revert "Use github arm64 runners (hyperledger#7054)" (hyperledger#7087)
e4e93e7 
This reverts commit 2a39f2c.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@siladu siladu mentioned this pull request Jun 4, 2024
Closed
@seanyoung seanyoung mentioned this pull request Jun 4, 2024
Merged
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@seanyoung @siladu @matthew1001
Use github arm64 runners (hyperledger#7054)
fff8758 
Signed-off-by: Sean Young <sean@mess.org>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@siladu @matthew1001
Revert "Use github arm64 runners (hyperledger#7054)" (hyperledger#7087)
2161673 
This reverts commit 2a39f2c.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
@seanyoung @siladu @jflo
Use github arm64 runners (hyperledger#7054)
620f543 
Signed-off-by: Sean Young <sean@mess.org>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
@siladu @jflo
Revert "Use github arm64 runners (hyperledger#7054)" (hyperledger#7087)
086ca99 
This reverts commit 2a39f2c.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@jflo jflo Awaiting requested review from jflo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from self-hosted hyp-ci-linux-arm64 to besu-arm64 runner
2 participants
@seanyoung @siladu