-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed tests for pki qbft and add deprecation notice #6979
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Think this failure is because we are getting timing info from the test report from previous run? And that name no longer exists - https://github.com/hyperledger/besu/actions/runs/8794044759/job/24132855802?pr=6979
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woop!
Can also remove some test infrastructure for PKI in AT DSL in BesuNode, ProcessBesuNodeRunner and ThreadBesuNodeRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more tests and resource that could be deleted now if you want. The acceptance-tests pki-certs in the test resources.
Also the CMS tests CmsCreationAndValidationTest
and CmsTestKeystores
which are part of the PKI feature in the pki module. Though they don't seem be causing in trouble so maybe they can stay till the big delete.
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
PR description
Remove tests for PKI-backed QBFT feature
Add deprecation notice
Fixed Issue(s)
fixes #6932
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests