Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for empty in disconnect reason bytes #6938

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

macfarla
Copy link
Contributor

PR description

Fix bug introduced in #6925
UNKNOWN disconnect reason has null code

Fixed Issue(s)

Fixes #6937

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what client is sending those?

@macfarla
Copy link
Contributor Author

Do we know what client is sending those?

I think the one I saw was an outgoing disconnect. But we do have some logs to analyse, can get some more data on this.

@macfarla macfarla merged commit 6699907 into hyperledger:main Apr 15, 2024
42 checks passed
siladu added a commit to siladu/besu that referenced this pull request Apr 15, 2024
This reverts commit 6699907.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla added a commit to macfarla/besu that referenced this pull request Apr 26, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the denylist-inddex-oob branch July 12, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeerDenylistManager index OOB exception
2 participants