Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flaky test - LegacyFeeMarketBlockTransactionSelectorTest #6851

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

macfarla
Copy link
Contributor

PR description

Fixed Issue(s)

refs #6850

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@macfarla macfarla enabled auto-merge (squash) March 29, 2024 22:03
@macfarla macfarla merged commit d926052 into hyperledger:main Mar 29, 2024
42 checks passed
@macfarla macfarla added the flake 60% of the time it works 100% of the time. label Apr 3, 2024
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…erledger#6851)

* disable flaky test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* added message to disabled annotation

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…erledger#6851)

* disable flaky test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* added message to disabled annotation

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
…erledger#6851)

* disable flaky test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* added message to disabled annotation

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 7, 2024
…erledger#6851)

* disable flaky test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* added message to disabled annotation

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the flaky-test-legacy-fee-market branch July 16, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake 60% of the time it works 100% of the time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants