Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend error handling of plugin RPC methods #6759

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 19, 2024

PR description

Fixed Issue(s)

Extend PluginRpcEndpointException so that it requires a RpcMethodError that will be used to format standard error responses.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 changed the title Extend error handlig of plugin RPC methods Extend error handling of plugin RPC methods Mar 19, 2024
@fab-10 fab-10 force-pushed the improve-plugin-rpc-error-handling branch from 67ceb03 to d23b36c Compare March 19, 2024 13:58
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the improve-plugin-rpc-error-handling branch from d23b36c to 99d35ee Compare March 19, 2024 16:13
@fab-10 fab-10 marked this pull request as ready for review March 19, 2024 16:18
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement, great test coverage.

@fab-10 fab-10 enabled auto-merge (squash) March 20, 2024 20:04
@fab-10 fab-10 merged commit 86cc6cb into hyperledger:main Mar 20, 2024
42 checks passed
@fab-10 fab-10 deleted the improve-plugin-rpc-error-handling branch March 21, 2024 11:14
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants