-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Besu custom error prone dependency #6692
Merged
Merged
Changes from 35 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
06bc097
Use external custom error prone dependency
usmansaleem c59b33e
spotless fix
usmansaleem 3ad6fb4
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem c3be7b4
custom errorprone check fail test
usmansaleem 613ac16
testing errorprone checks
usmansaleem c8d2e0f
Using latest version of google errorprone
usmansaleem e33b131
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 9e43c2a
errorprone reported fix
usmansaleem f65fd38
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 6283277
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 28847c2
Add suppression for ComparisonOutOfRange
usmansaleem 06e8a21
Resolve errorprone locally
usmansaleem 1f18502
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 652a840
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem d8ac80e
build: Update besu errorprone library version
usmansaleem 8536cc0
chore: Revert changes to StorageRangeDataRequest
usmansaleem abc5e43
chore: Remove mavanLocal used in local testing
usmansaleem 9c9bee7
chore: Cleanup StringBuilder
usmansaleem 01d72f3
errorprone: Fix reported issues
usmansaleem 345e499
chore: Fix supress warning typo
usmansaleem b13262d
fix: Fix invalid assertion
usmansaleem 456b6bd
errorprone: Fix reported issues
usmansaleem 71a2fa7
chore: spotless apply
usmansaleem becbbb0
fix: Remove custom error prone source
usmansaleem 988310c
chore: Remove comment from build.gradle
usmansaleem a2c1ab2
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 1a28596
chore: Update gradle verification metadata
usmansaleem 597a920
chore: Update gradle verification metadata
usmansaleem 3afd788
chore: Update gradle verification metadata
usmansaleem e96c52c
chore: Update gradle verification metadata
usmansaleem 72ee8cb
chore: Update fixing gradle verification metadata
usmansaleem 603c21d
build: Update build.gradle, removing temporary errorprone check
usmansaleem 095c112
build: verification metadata for spotless
usmansaleem cb8f07a
build: verification metadata for spotless
usmansaleem 6ad2b70
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 6b77b18
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 13b9607
review: Simplify checkHostInAllowlist logic
usmansaleem fa9053e
review: Change TreeMap to NavigatableMap
usmansaleem ecacd19
review: Change TreeMap to NavigatableMap
usmansaleem 4287430
Merge remote-tracking branch 'upstream/main' into werror_issue
usmansaleem 0dd03d4
review: Change TreeMap to NavigableMap
usmansaleem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were warnings in build.gradle file that will be an issue in future release of gradle. Although they should not be technically part of this PR, I fixed them originally while researching this problem and were using debug flags to the build.