Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR https://github.com/hyperledger/besu/pull/6187 #6232

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

pinges
Copy link
Contributor

@pinges pinges commented Dec 5, 2023

PR description

This PR reverts #6187. The PR causes syncing problems by not removing useless peers.

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Copy link

github-actions bot commented Dec 5, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@pinges pinges merged commit ee810eb into hyperledger:main Dec 5, 2023
@pinges pinges deleted the revert6187 branch December 5, 2023 06:18
@macfarla macfarla mentioned this pull request Dec 5, 2023
jflo pushed a commit to jflo/besu that referenced this pull request Dec 5, 2023
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 5, 2023
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo added a commit that referenced this pull request Dec 5, 2023
* revert (#6232)

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>

* uprev to RC2

Signed-off-by: Justin Florentine <justin+github@florentine.us>

* Update Gradle verification metadata (#6236)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants