Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub ci testing pr #6214

Merged
merged 0 commits into from
Dec 5, 2023
Merged

GitHub ci testing pr #6214

merged 0 commits into from
Dec 5, 2023

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Nov 29, 2023

DO NOT MERGE

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated comment, existing review

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new comment

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fake approved!

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good jorb

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes units

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex is wrong

@macfarla
Copy link
Contributor

I'm excited for parallel unit tests!

jflo
jflo commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super exciting indeed

@jflo jflo changed the base branch from github_ci to main December 4, 2023 19:43
@jflo jflo force-pushed the github_ci branch 2 times, most recently from 6b990ff to 74c9b31 Compare December 4, 2023 19:52
@jflo jflo changed the base branch from main to github_ci December 4, 2023 19:59
@jflo jflo force-pushed the github_ci branch 4 times, most recently from da9a239 to c257863 Compare December 5, 2023 17:31
@jflo jflo merged commit c257863 into hyperledger:github_ci Dec 5, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @macfarla