Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved some logs to trace level #6207

Merged
merged 12 commits into from
Nov 30, 2023
Merged

moved some logs to trace level #6207

merged 12 commits into from
Nov 30, 2023

Conversation

macfarla
Copy link
Contributor

  • move "Requesting x headers" etc to trace level logging
  • use peer.shortNodeId rather than logging the whole peer record
  • move "Wrote initial crypto handshake message" to trace
  • also a couple of frequently logged tx pool logs

@macfarla
moved some logs to trace level
00413a7 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla
Copy link
Contributor Author

left ChainHeadTracker at debug but use shortNodeId for peer

2023-11-28 12:28:12.635+10:00 | nioEventLoopGroup-3-2 | DEBUG | ChainHeadTracker | Requesting chain head info from 0xcbbaacaf47a005cb38...
2023-11-28 12:28:12.635+10:00 | nioEventLoopGroup-3-3 | DEBUG | ChainHeadTracker | Requesting chain head info from 0x4d33b9dad0673b51f9...
2023-11-28 12:28:12.635+10:00 | nioEventLoopGroup-3-1 | DEBUG | ChainHeadTracker | Requesting chain head info from 0x14ba040dd8c5b1ea60...
2023-11-28 12:28:12.635+10:00 | nioEventLoopGroup-3-6 | DEBUG | ChainHeadTracker | Requesting chain head info from 0x82b8a8b80c6c37caad...
2023-11-28 12:28:12.635+10:00 | nioEventLoopGroup-3-5 | DEBUG | ChainHeadTracker | Requesting chain head info from 0x45d51ba278b725d979...
2023-11-28 12:28:12.636+10:00 | nioEventLoopGroup-3-4 | DEBUG | ChainHeadTracker | Requesting chain head info from 0xc7d29d1bbb768e73c6...
2023-11-28 12:28:12.645+10:00 | nioEventLoopGroup-3-4 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.645+10:00 | nioEventLoopGroup-3-2 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.649+10:00 | nioEventLoopGroup-3-1 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.647+10:00 | nioEventLoopGroup-3-6 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.649+10:00 | nioEventLoopGroup-3-3 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.648+10:00 | nioEventLoopGroup-3-5 | DEBUG | WaitForPeerTask | Finished waiting for peer connection.
2023-11-28 12:28:12.649+10:00 | nioEventLoopGroup-3-4 | INFO  | FullSyncTargetManager | Unable to find sync target. Currently checking 6 peers for usefulness
2023-11-28 12:28:12.665+10:00 | nioEventLoopGroup-3-4 | DEBUG | WaitForPeerTask | Waiting for new peer connection. 6 peers currently connected.
2023-11-28 12:28:13.120+10:00 | nioEventLoopGroup-3-2 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0xcbbaacaf47a005cb38...
2023-11-28 12:28:13.120+10:00 | nioEventLoopGroup-3-1 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0x14ba040dd8c5b1ea60...
2023-11-28 12:28:13.120+10:00 | nioEventLoopGroup-3-3 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0x4d33b9dad0673b51f9...
2023-11-28 12:28:13.120+10:00 | nioEventLoopGroup-3-4 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0xc7d29d1bbb768e73c6...
2023-11-28 12:28:13.123+10:00 | nioEventLoopGroup-3-5 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0x45d51ba278b725d979...
2023-11-28 12:28:13.231+10:00 | nioEventLoopGroup-3-6 | DEBUG | ChainHeadTracker | Retrieved chain head info 2253462 (0x71a6a92bfab342e8881834dfd8e77e359382a02ac16c5f46f8d94befec4b0241) from 0x82b8a8b80c6c37caad...

@macfarla
more trace level
518ef0f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added dev experience The build system, things that enable easier development etc. logging ux labels Nov 28, 2023
gfukushima
gfukushima approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...n/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java Outdated Show resolved Hide resolved
@macfarla
shortNodeId
c6c29a3 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
shortNodeId
2eb6d4f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
fab-10
fab-10 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested performance opt to avoid execution and memory allocation when not at trace

...i/src/main/java/org/hyperledger/besu/ethereum/api/query/cache/TransactionLogBloomCacher.java Outdated Show resolved Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeer.java Outdated Show resolved Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeer.java Outdated Show resolved Hide resolved
...main/java/org/hyperledger/besu/ethereum/eth/manager/task/AbstractGetHeadersFromPeerTask.java Outdated Show resolved Hide resolved
...hyperledger/besu/ethereum/eth/manager/task/BufferedGetPooledTransactionsFromPeerFetcher.java Outdated Show resolved Hide resolved
...n/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java Outdated Show resolved Hide resolved
...th/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetReceiptsFromPeerTask.java Outdated Show resolved Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/ChainHeadTracker.java Outdated Show resolved Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/ChainHeadTracker.java Outdated Show resolved Hide resolved
...g/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageProcessor.java Outdated Show resolved Hide resolved
@macfarla
shortNodeId
7c8b07e 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
merge
759193c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
pr review
f4b0c54 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

Thanks for the review @fab-10 have actioned your comments

@fab-10
Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/m…
a750b66 
…anager/task/BufferedGetPooledTransactionsFromPeerFetcher.java

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Apply suggestions from code review
f278102 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
fab-10 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more little opt, then ok

...i/src/main/java/org/hyperledger/besu/ethereum/api/query/cache/TransactionLogBloomCacher.java Outdated Show resolved Hide resolved
...g/hyperledger/besu/ethereum/eth/transactions/NewPooledTransactionHashesMessageProcessor.java Outdated Show resolved Hide resolved
...c/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetHeadersFromPeerByHashTask.java Show resolved Hide resolved
fab-10 and others added 3 commits November 30, 2023 09:53
@fab-10
Update ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/q…
53a6ecb 
…uery/cache/TransactionLogBloomCacher.java

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/t…
101dc5f 
…ransactions/NewPooledTransactionHashesMessageProcessor.java

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@macfarla
lambda
c25b70d 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) November 30, 2023 09:21
@macfarla macfarla merged commit fd187bc into hyperledger:main Nov 30, 2023
18 checks passed
@macfarla macfarla deleted the trace-logging branch December 1, 2023 03:50
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@macfarla @fab-10 @jflo
moved some logs to trace level (hyperledger#6207)
954ca4e 
* moved some logs to trace level

* shortNodeId

* Apply suggestions from code review

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@macfarla @fab-10 @jflo
moved some logs to trace level (hyperledger#6207)
41c846e 
* moved some logs to trace level

* shortNodeId

* Apply suggestions from code review

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@macfarla @fab-10 @jflo
moved some logs to trace level (hyperledger#6207)
41d34a3 
* moved some logs to trace level

* shortNodeId

* Apply suggestions from code review

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
@macfarla @fab-10 @gfukushima
moved some logs to trace level (hyperledger#6207)
8b251eb 
* moved some logs to trace level

* shortNodeId

* Apply suggestions from code review

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

@fab-10 fab-10 fab-10 approved these changes

@garyschulte garyschulte Awaiting requested review from garyschulte

Assignees
No one assigned
Labels
dev experience The build system, things that enable easier development etc. logging ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macfarla @gfukushima @fab-10