Allow a transaction selection plugin to specify custom selection results #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fab-10
force-pushed
the
block-tx-selection-log-fixes
branch
from
0e80f70
to
a1230fc
Compare
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
block-tx-selection-log-fixes
branch
from
a1230fc
to
a82a507
Compare
Gabriel-Trintinalia
approved these changes
Nov 21, 2023
| @@ -1189,4 +1192,48 @@ protected MiningParameters createMiningParameters( | |||
| .build()) | |||
| .build(); | |||
| } | |||
|
|
|||
| private static class PluginTrasactionSelectionResult extends TransactionSelectionResult { | |||
There was a problem hiding this comment.
typo here -> PluginTraNsactionSelectionResult
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…lts (hyperledger#6190) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…lts (hyperledger#6190) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…lts (hyperledger#6190) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
…lts (hyperledger#6190) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
With this PR a transaction selection plugin can extend TransactionSelectionResult to implement its custom return values.
Plus a couple of log fixes.