Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added shouldOverrideBuilder field to engine_getPayloadV3 response #5780

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Aug 21, 2023

simply default to false for now.

This should fix some failing hive tests.

fixes #5739

…etPayloadV3 response

default to false

[skip ci]

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) August 22, 2023 01:05
@macfarla macfarla merged commit c3c7205 into hyperledger:main Aug 22, 2023
8 checks passed
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
…etPayloadV3 response (hyperledger#5780)

default to false

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
…etPayloadV3 response (hyperledger#5780)

default to false

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
…etPayloadV3 response (hyperledger#5780)

default to false

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@macfarla macfarla deleted the fix/issue-5739/should-override-builder-default branch September 13, 2023 06:07
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…etPayloadV3 response (hyperledger#5780)

default to false

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement shouldOverrideBuilder in engine_getPayloadV3
2 participants