-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added shouldOverrideBuilder field to engine_getPayloadV3 response #5780
Merged
macfarla
merged 3 commits into
hyperledger:main
from
macfarla:fix/issue-5739/should-override-builder-default
Aug 22, 2023
Merged
fix: added shouldOverrideBuilder field to engine_getPayloadV3 response #5780
macfarla
merged 3 commits into
hyperledger:main
from
macfarla:fix/issue-5739/should-override-builder-default
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etPayloadV3 response default to false [skip ci] Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
|
Gabriel-Trintinalia
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
…etPayloadV3 response (hyperledger#5780) default to false Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
…etPayloadV3 response (hyperledger#5780) default to false Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
…etPayloadV3 response (hyperledger#5780) default to false Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…etPayloadV3 response (hyperledger#5780) default to false Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simply default to false for now.
This should fix some failing hive tests.
fixes #5739