Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use retry switching peer for world state download tasks #5508

Closed
wants to merge 34 commits into from
Closed

Use retry switching peer for world state download tasks #5508

wants to merge 34 commits into from

Commits on May 29, 2023

  1. Use AbstractRetryingSwitchingPeerTask whenever it makes sense 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    8b76085 View commit details
    Browse the repository at this point in the history

  2. Introduce a PoS friendly fast sync target manager 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    784b08f View commit details
    Browse the repository at this point in the history

  3. Require that best peers are fully validated 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    589f89f View commit details
    Browse the repository at this point in the history

  4. Move PoS sync targe in another branch 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a924542 View commit details
    Browse the repository at this point in the history

  5. Record empty responses when retrying a peer task 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    1378afc View commit details
    Browse the repository at this point in the history

  6. Review and consolidate the way result is set in retrying tasks 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a20c5ed View commit details
    Browse the repository at this point in the history

  7. Merge branch 'demote-peer-with-empty-responses-when-retrying' into us… 

    …e-retry-switching-peer

# Conflicts:
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetAccountRangeFromPeerTask.java
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetBytecodeFromPeerTask.java
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetStorageRangeFromPeerTask.java
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetTrieNodeFromPeerTask.java
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/RetryingGetNodeDataFromPeerTask.java
    @fab-10
    fab-10 committed May 29, 2023
    Configuration menu
    Copy the full SHA
    bd71628 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge branch 'main' into demote-peer-with-empty-responses-when-retrying

    @fab-10
    fab-10 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    82051cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'demote-peer-with-empty-responses-when-retrying' into us… 

    …e-retry-switching-peer
    @fab-10
    fab-10 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a80a73f View commit details
    Browse the repository at this point in the history

  3. Fix: always use the root cause to check the errors 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    c695c32 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'demote-peer-with-empty-responses-when-retrying' into us… 

    …e-retry-switching-peer
    @fab-10
    fab-10 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    69b94d5 View commit details
    Browse the repository at this point in the history

  5. Adapt unit tests 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    ed2def6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'main' into demote-peer-with-empty-responses-when-retrying

    @fab-10
    fab-10 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ea4a469 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'demote-peer-with-empty-responses-when-retrying' into us… 

    …e-retry-switching-peer
    @fab-10
    fab-10 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1929945 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. merge main 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d590fbf View commit details
    Browse the repository at this point in the history

  2. fix annotation 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    419e9be View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'main' of github.com:hyperledger/besu into use-retry-swi… 

    …tching-peer
    @pinges
    pinges committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0dde76d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. fix peer lookup to include unfinished connections 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5ee3d48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:hyperledger/besu into use-retry-swi… 

    …tching-peer
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ec897ab View commit details
    Browse the repository at this point in the history

  3. check can exceed in all cases 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b62c7a2 View commit details
    Browse the repository at this point in the history

  4. add debug log for disconnecting an established peer 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a337253 View commit details
    Browse the repository at this point in the history

  5. fix compile 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    bb7cbd1 View commit details
    Browse the repository at this point in the history

  6. fix unit test 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cbca445 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. print message when not expected 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    24a96a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:hyperledger/besu into use-retry-swi… 

    …tching-peer
    @pinges
    pinges committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c26fea6 View commit details
    Browse the repository at this point in the history

  3. really print the data 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    addcfcd View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. do not report useless for got storage range 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    93b772a View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. two more tasks should not report useless responses 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b9265e2 View commit details
    Browse the repository at this point in the history

  2. one more task 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    2e2e48f View commit details
    Browse the repository at this point in the history

  3. add java doc to new method 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e98213c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. check whether an empty response needs to be reported 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2b05f8b View commit details
    Browse the repository at this point in the history

  2. merge main 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c22e28d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. make sure peers support snap 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b2ab6d7 View commit details
    Browse the repository at this point in the history

  2. make sure peers support snap 

    Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
    @pinges
    pinges committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3209a37 View commit details
    Browse the repository at this point in the history