NewBlockHeaders performance improvement #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending out new block headers to the websocket subscribers we serialized the block once per each subscriber. This had some crypto calls for each serialization and was CPU bound with redundant calculations. We can memoize the result and only serialize it once per block. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
ajsutton
approved these changes
Nov 29, 2019
|
Unit tests actually had a mock to enforce that we only create blocks when we need them. I'll update this monday or so to have the tests verify no-more-than-once as well. |
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
* NewBlockHeaders performance improvement When sending out new block headers to the websocket subscribers we serialized the block once per each subscriber. This had some crypto calls for each serialization and was CPU bound with redundant calculations. We can memoize the result and only serialize it once per block. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
* NewBlockHeaders performance improvement When sending out new block headers to the websocket subscribers we serialized the block once per each subscriber. This had some crypto calls for each serialization and was CPU bound with redundant calculations. We can memoize the result and only serialize it once per block. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending out new block headers to the websocket subscribers we
serialized the block once per each subscriber. This had some crypto
calls for each serialization and was CPU bound with redundant
calculations.
We can memoize the result and only serialize it once per block.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Changelog
n/a