Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

besu - migrate tests from Junit4 to Junit5 #5571

Closed
macfarla opened this issue Jun 9, 2023 · 6 comments · Fixed by #6338
Closed

besu - migrate tests from Junit4 to Junit5 #5571

macfarla opened this issue Jun 9, 2023 · 6 comments · Fixed by #6338
Assignees
@macfarla
Labels
good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing

Comments

@macfarla
Copy link
Contributor

macfarla commented Jun 9, 2023

Module besu
eg
public class RlpBlockImporterTest

Here's an example https://github.com/hyperledger/besu/pull/5525/files
@macfarla macfarla added good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing labels Jun 9, 2023
@0xBlockPay
Copy link

Hi :) I asked on discord about assign this task to me :)

@0xBlockPay 0xBlockPay mentioned this issue Jul 14, 2023
Closed
@macfarla
Copy link
Contributor Author

hey @0xBlockPay are you still interested in working on this one? hopefully the blockers are out of the way now! Otherwise I will unassign you

@fspirola
Copy link
Contributor

@macfarla please, can you assign this issue to me.

@jflo
Copy link
Contributor

jflo commented Oct 31, 2023

assigned, have fun!

fspirola added a commit to fspirola/besu that referenced this issue Nov 4, 2023
@fspirola
hyperledger#5571 besu - migrate tests from Junit4 to Junit5
6a5ebf1 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
@fspirola fspirola mentioned this issue Nov 5, 2023
Closed
fspirola added a commit to fspirola/besu that referenced this issue Nov 5, 2023
@fspirola
hyperledger#5571 besu - migrate tests from Junit4 to Junit5
61c0421 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
fspirola added a commit to fspirola/besu that referenced this issue Nov 7, 2023
@fspirola
[hyperledger#5571] besu - migrate tests from Junit4 to Junit5
5f73b46 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
fspirola added a commit to fspirola/besu that referenced this issue Nov 7, 2023
@fspirola
[hyperledger#5571] remove ide files
71f148b 
Signed-off-by: Fabio Pirola <fspirola@gmail.com>
macfarla added a commit that referenced this issue Nov 21, 2023
@fspirola @macfarla
[#5561]migrate tests to junit5 (#6122)
d94ea77 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
@fspirola
Copy link
Contributor

@jflo Done. This issue was resolved by PR #6122

jflo pushed a commit to jflo/besu that referenced this issue Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
1cff6b7 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this issue Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
401cbb7 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this issue Dec 4, 2023
@fspirola @macfarla @jflo
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
a85d4fe 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@macfarla
Copy link
Contributor Author

macfarla commented Dec 5, 2023

done!

@macfarla macfarla closed this as completed Dec 5, 2023
This was referenced Dec 12, 2023
Merged
Merged
Merged
@macfarla macfarla reopened this Dec 12, 2023
@macfarla macfarla assigned macfarla and unassigned fspirola Dec 12, 2023
gfukushima pushed a commit to gfukushima/besu that referenced this issue Dec 15, 2023
@fspirola @macfarla @gfukushima
[hyperledger#5561]migrate tests to junit5 (hyperledger#6122)
865370c 
* migrate teste from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* migrate test from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* hyperledger#5571 besu - migrate tests from Junit4 to Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5571migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* #5561migrate-tests-to-Junit5

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

* [hyperledger#5561] remove ide files

Signed-off-by: Fabio Pirola <fspirola@gmail.com>

---------

Signed-off-by: Fabio Pirola <fspirola@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@macfarla macfarla mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

Labels
good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MINOR] migrate controller builder test junit5 macfarla/besu
4 participants
@jflo @macfarla @fspirola @0xBlockPay