Skip to content

Commit

Permalink
[MINOR] - Add plugin version summary (#6221)
Browse files Browse the repository at this point in the history
* Add plugin version to summary on startup

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Remove test code

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
  • Loading branch information
Gabriel-Trintinalia authored Dec 1, 2023
1 parent 3ec078a commit bbb6c83
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ public void registerPlugins(final Path pluginsDir) {
try {
plugin.register(this);
LOG.info("Registered plugin of type {}.", plugin.getClass().getName());
lines.add(String.format(plugin.getClass().getSimpleName()));
addPluginVersion(plugin);
String pluginVersion = getPluginVersion(plugin);
pluginVersions.add(pluginVersion);
lines.add(String.format("%s (%s)", plugin.getClass().getSimpleName(), pluginVersion));
} catch (final Exception e) {
LOG.error(
"Error registering plugin of type "
Expand Down Expand Up @@ -156,7 +157,7 @@ public List<String> getPluginsSummaryLog() {
return lines;
}

private void addPluginVersion(final BesuPlugin plugin) {
private String getPluginVersion(final BesuPlugin plugin) {
final Package pluginPackage = plugin.getClass().getPackage();
final String implTitle =
Optional.ofNullable(pluginPackage.getImplementationTitle())
Expand All @@ -166,8 +167,7 @@ private void addPluginVersion(final BesuPlugin plugin) {
Optional.ofNullable(pluginPackage.getImplementationVersion())
.filter(Predicate.not(String::isBlank))
.orElse("<Unknown Version>");
final String pluginVersion = implTitle + "/v" + implVersion;
pluginVersions.add(pluginVersion);
return implTitle + "/v" + implVersion;
}

/** Before external services. */
Expand Down

0 comments on commit bbb6c83

Please sign in to comment.