Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --Xsnapsync-bft-enabled #1739

Merged
merged 10 commits into from
Mar 13, 2025
Merged

Remove --Xsnapsync-bft-enabled #1739

merged 10 commits into from
Mar 13, 2025
+5 −43

Conversation

pullurib
Copy link
Contributor

Description

Issue(s) fixed

#7924

Fixes #

Add documentation for snapsync-bft-enabled option
55abb6e 
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
@pullurib pullurib requested a review from a team as a code owner November 26, 2024 20:18
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 0:38am

alexandratran
alexandratran reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Since this option only applies to private networks (IBFT 2.0 and QBFT networks), can you move this documentation to the private networks command line options reference page?

Move the option usage to private networks
8738293 
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
@alexandratran alexandratran mentioned this pull request Nov 27, 2024
Merged
@macfarla
Copy link
Contributor

ok per comments on the besu PR this option is being removed altogether

Update docs about --Xsnapsync-bft-enabled deprecation and removal in …
c2f3932 
…future release

Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
@pullurib pullurib changed the title Add documentation for snapsync-bft-enabled option Add --Xsnapsync-bft-enabled deprecation notice Nov 28, 2024
Bhanu Pulluri and others added 2 commits November 28, 2024 12:26
Revert private options change
770c20b 
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
@pullurib
Merge branch 'main' into 7924-bft-snapsync
6263b6a
fix a typo
70d8668 
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Fix formatting
0e7c449 
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
macfarla reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just remove this content altogether when this option is no longer needed (deprecated)

remove all notes
e81d09e 
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
alexandratran
alexandratran approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all mentions of --Xsnapsync-bft-enabled because snap sync is now supported without the experimental flag.

@alexandratran alexandratran changed the title Add --Xsnapsync-bft-enabled deprecation notice Remove --Xsnapsync-bft-enabled Dec 3, 2024
macfarla
macfarla approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but might be good to wait until hyperledger/besu#7930 is merged - right now you do still need to use --Xsnap-bft-enabled if you want to use SNAP on BFT networks (then again, anyone who needs to use that flag prob already knows about it)

@macfarla
Copy link
Contributor

still waiting on the Besu PR - apologies for jumping the gun on this one. I'll make this one draft for now.

@macfarla macfarla marked this pull request as draft February 25, 2025 02:05
@macfarla macfarla marked this pull request as ready for review March 13, 2025 00:36
@macfarla macfarla enabled auto-merge (squash) March 13, 2025 00:37
@macfarla macfarla merged commit d765b69 into hyperledger:main Mar 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pullurib @macfarla @alexandratran