Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ledger error when registering nym after multi-ledger switch #2496

Closed
wants to merge 3 commits into from

Conversation

shaangill025
Copy link
Contributor

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shaangill025 shaangill025 marked this pull request as ready for review September 20, 2023 01:34
@WadeBarnes
Copy link
Member

WadeBarnes commented Sep 20, 2023

Built an Askar only ACA-Py 0.11.0-pr2496-pre0 prerelease image for this PR; ACA-Py 0.11.0-pr2496-pre0

cc @shaangill025

Copy link
Contributor

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, however I'd ask someone else (@usingtechnology maybe?) to take a quick pass and approve since I am not as deep in the code and might have missed something (and don;t have the power to approve "for real" anyway 🙂 ).

@usingtechnology
Copy link
Contributor

same for me @esune. code makes sense and looks ok to me. can we get someone from the traction team to attempt reproducing this error using this code?

something like this in poetry...

aries-cloudagent = { git = "https://github.com/hyperledger/aries-cloudagent-python", rev = "ee67a59a3a84fcc1f87c59d65aef28202ffad99c" }

@esune
Copy link
Contributor

esune commented Sep 25, 2023

same for me @esune. code makes sense and looks ok to me. can we get someone from the traction team to attempt reproducing this error using this code?

something like this in poetry...

aries-cloudagent = { git = "https://github.com/hyperledger/aries-cloudagent-python", rev = "ee67a59a3a84fcc1f87c59d65aef28202ffad99c" }

@shaangill025 mentioned he is still getting an error during stand-up this morning so we might want to wait for an update from him regarding further testing

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm
Copy link
Member

dbluhm commented Feb 13, 2024

OBE -- this continues to be an issue that we want to address but will probably need to start fresh.
@esune voluntold to write us a note in the docs for 1.0.0

@dbluhm dbluhm closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger error when completing txn with multiledger enabled
5 participants