linting pass

Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>

integration/soroban/test_helpers.js

@@ -2,7 +2,7 @@ import * as StellarSdk from '@stellar/stellar-sdk';
 
 
 
-async function call_contract_function(method, server, keypair, contract) {
+export async function call_contract_function(method, server, keypair, contract) {
 
     let res;
     let builtTransaction = new StellarSdk.TransactionBuilder(await server.getAccount(keypair.publicKey()), {
@@ -50,6 +50,4 @@ async function call_contract_function(method, server, keypair, contract) {
       console.log(err);
     }
     return res;
-}
-
-export { call_contract_function };
+}

src/codegen/dispatch/soroban.rs

@@ -25,10 +25,6 @@ pub fn function_dispatch(
     let mut wrapper_cfgs = Vec::new();
 
     for cfg in all_cfg.iter_mut() {
-        if cfg.function_no == ASTFunction::None {
-            continue;
-        }
-
         let function = match &cfg.function_no {
             ASTFunction::SolidityFunction(no) => &ns.functions[*no],
             _ => continue,

src/emit/binary.rs

@@ -792,7 +792,6 @@ impl<'a> Binary<'a> {
                 None => return self.context.void_type().fn_type(&args, false),
             }
         }
-
         // add return values
         for ty in returns {
             args.push(if ty.is_reference_type(ns) && !ty.is_contract_storage() {

src/emit/instructions.rs

@@ -59,7 +59,6 @@ pub(super) fn process_instruction<'a, T: TargetRuntime<'a> + ?Sized>(
         Instr::Return { value } => match value.iter().next() {
             Some(val) => {
                 let retval = expression(target, bin, val, &w.vars, function, ns);
-
                 bin.builder.build_return(Some(&retval)).unwrap();
             }
             None => {
@@ -462,7 +461,7 @@ pub(super) fn process_instruction<'a, T: TargetRuntime<'a> + ?Sized>(
                 .map(|p| expression(target, bin, p, &w.vars, function, ns).into())
                 .collect::<Vec<BasicMetadataValueEnum>>();
 
-            // Soroban doesnt write return values to imported memory
+            // Soroban doesn't write return values to imported memory
             if !res.is_empty() && ns.target != Target::Soroban {
                 for v in f.returns.iter() {
                     parms.push(if ns.target == Target::Solana {
@@ -488,7 +487,7 @@ pub(super) fn process_instruction<'a, T: TargetRuntime<'a> + ?Sized>(
                 .try_as_basic_value()
                 .left();
 
-            // Soroban doesnt have return codes, and only returns a single i64 value
+            // Soroban doesn't have return codes, and only returns a single i64 value
             if ns.target != Target::Soroban {
                 let success = bin
                     .builder

src/emit/soroban/mod.rs

@@ -96,7 +96,7 @@ impl SorobanTarget {
                 } else {
                     &cfg.name
                 };
-                Self::emit_function_spec_entry(context, cfg.clone(), name.to_string(), binary);
+                Self::emit_function_spec_entry(context, cfg, name.to_string(), binary);
                 export_list.push(name);
                 Linkage::External
             } else {
@@ -124,7 +124,6 @@ impl SorobanTarget {
 
         for (func_decl, cfg) in defines {
             emit_cfg(&mut SorobanTarget, binary, contract, cfg, func_decl, ns);
-            //Self::emit_function_dispatcher(binary, cfg, func_decl, &dispatcher_name, ns, &contract);
         }
     }
 
@@ -140,14 +139,12 @@ impl SorobanTarget {
 
     fn emit_function_spec_entry<'a>(
         context: &'a Context,
-        cfg: ControlFlowGraph,
+        cfg: &ControlFlowGraph,
         name: String,
         binary: &mut Binary<'a>,
     ) {
         if cfg.public && !cfg.is_placeholder() {
             // TODO: Emit custom type spec entries
-            //let outputs = ScSpecTypeDef::Vec(());
-
             let mut spec = DepthLimitedWrite::new(Vec::new(), 10);
             ScSpecEntry::FunctionV0(ScSpecFunctionV0 {
                 name: name
@@ -249,7 +246,7 @@ impl SorobanTarget {
         let void_param = ast::Parameter::new_default(ast::Type::Void);
         cfg.returns = sync::Arc::new(vec![void_param]);
 
-        Self::emit_function_spec_entry(binary.context, cfg, "init".to_string(), binary);
+        Self::emit_function_spec_entry(binary.context, &cfg, "init".to_string(), binary);
 
         let function_name = CString::new(STORAGE_INITIALIZER).unwrap();
         let mut storage_initializers = binary

src/emit/soroban/target.rs

@@ -85,7 +85,7 @@ impl<'a> TargetRuntime<'a> for SorobanTarget {
                         .const_cast(binary.context.i64_type(), false)
                         .into(),
                     dest.into(),
-                    i64_const!(2).into(),
+                    binary.context.i64_type().const_int(2, false).into(),
                 ],
                 PUT_CONTRACT_DATA,
             )
@@ -235,6 +235,7 @@ impl<'a> TargetRuntime<'a> for SorobanTarget {
     }
 
     /// Prints a string
+    /// TODO: Implement this function, with a call to the `log` function in the Soroban runtime.
     fn print(&self, bin: &Binary, string: PointerValue, length: IntValue) {}
 
     /// Return success without any result