remove todos from crypto library #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KAO <kao@zurich.ibm.com>
Signed-off-by: KAO <kao@zurich.ibm.com>
adecaro
reviewed
Dec 14, 2022
token/core/zkatdlog/crypto/setup.go
Outdated
| // the curve exists | ||
| // the idemix params are all set, | ||
| // and so on | ||
| err := pp.Validate() |
There was a problem hiding this comment.
do we perform the checks listed in the todo?
There was a problem hiding this comment.
Shall we remove this from here? The developer can call validate after deserialization.
There was a problem hiding this comment.
Validate perform all checks. Do you mean that we do not validate the public parameters here?
Signed-off-by: KAO <kao@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KAO kao@zurich.ibm.com