load public params from vault when possible #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the public params are avaible in the vault, they are loaded. Otherwise, the committ pipeline will set them eventually. Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…n. If the public params are avaible in the vault, they are loaded. Otherwise, the committ pipeline will set them eventually. Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…n. If the public params are avaible in the vault, they are loaded. Otherwise, the committ pipeline will set them eventually. Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…n. If the public params are avaible in the vault, they are loaded. Otherwise, the committ pipeline will set them eventually. Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…n. If the public params are avaible in the vault, they are loaded. Otherwise, the committ pipeline will set them eventually. Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
HagarMeir
reviewed
Dec 4, 2022
| @@ -209,6 +209,9 @@ var BobAcceptedTransactions = []*ttxdb.TransactionRecord{ | |||
| func TestAll(network *integration.Infrastructure, auditor string) { | |||
| RegisterAuditor(network, auditor) | |||
|
|
|||
| // give some time to the nodes to get the public parameters | |||
| time.Sleep(10 * time.Second) | |||
There was a problem hiding this comment.
Is there a way to move this sleep somewhere so it doesn't have to appear at the beginning of each test?
HagarMeir
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following: At bootstrap, the stack first tries to load the public parameters from the local vault.
If the public parameters are not found and are nevertheless required, they are fetched from the remote network.