Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add iroha transaction get and other important commands #5289

Merged
merged 18 commits into from
Feb 13, 2025
Merged

feat(cli): add iroha transaction get and other important commands #5289

merged 18 commits into from
Feb 13, 2025

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Jan 27, 2025 •
edited
Loading

Context

Implements essential but previously missing commands in the client CLI. See Command Line Help

Migration Guide

Some commands are changed in usage or behavior:

  • iroha json query -> iroha query stdin
  • iroha json transaction -> iroha transaction stdin
  • iroha wasm -> iroha transaction wasm
  • iroha * metadata -> iroha * meta
  • iroha asset
    • get-key-value -> getkv
    • set-key-value -> setkv
    • remove-key-value -> removekv
  • iroha events
    • data -> state
    • transaction-pipeline -> transaction
    • block-pipeline -> block
    • execute-trigger -> trigger-execute
    • trigger-completed -> trigger-complete
  • iroha * list all -> iroha * list all --verbose
  • iroha * list all lists only IDs and is intended to be used in combination with iroha * get --id, which retrieves the details of a single entry.

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

s8sato added 2 commits January 27, 2025 18:26
@s8sato
fix: un-flatten enum Level to serialize
7e7bb53 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
feat(cli): add iroha transaction get and other important commands
abbf9ee 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato added the Enhancement New feature or request label Jan 27, 2025
@s8sato s8sato self-assigned this Jan 27, 2025
This was referenced Jan 27, 2025
Merged
Merged
@s8sato s8sato marked this pull request as ready for review January 27, 2025 10:13
s8sato
s8sato commented Jan 27, 2025
View reviewed changes
@s8sato s8sato added the CLI label Jan 27, 2025
s8sato added 2 commits January 28, 2025 23:47
@s8sato
Merge branch 'main' into feat/complete_cli
ae603bf
@s8sato
chore: remove scripts/tests/tick.json
bab15fc 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato mentioned this pull request Jan 28, 2025
Closed
s8sato added 5 commits February 5, 2025 02:19
@s8sato
docs: fix invalid links
f6bc207 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
ci: exclude from coverage iroha_cli iroha_torii covered by pytests
0cf5dd6 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
ci: complement hyperledger-iroha#4605: tag not iroha2:* but iroha:*
1172386 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
fixup! feat(cli): add iroha transaction get and other important com…
84bbd59 
…mands

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
Merge branch 'main' into feat/complete_cli
1c5adf3
@s8sato s8sato force-pushed the feat/complete_cli branch from 4f5d6d5 to 1c5adf3 Compare February 4, 2025 17:22
@s8sato
ci: fix iroha_wasm_builder usage
bdff4af 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
aoyako
aoyako previously approved these changes Feb 5, 2025
View reviewed changes
s8sato added 2 commits February 7, 2025 13:56
@s8sato
fixup! feat(cli): add iroha transaction get and other important com…
042e457 
…mands

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
docs: fix lints
f034223 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
fixup! feat(cli): add iroha transaction get and other important com…
8bcdcac 
…mands

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato force-pushed the feat/complete_cli branch from 0093bea to 8bcdcac Compare February 7, 2025 07:30
@s8sato
fixup! feat(cli): add iroha transaction get and other important com…
31402c7 
…mands

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
s8sato
s8sato commented Feb 7, 2025
View reviewed changes
aoyako
aoyako previously approved these changes Feb 12, 2025
View reviewed changes
mversic
mversic previously approved these changes Feb 12, 2025
View reviewed changes
@s8sato s8sato marked this pull request as draft February 12, 2025 14:03
@s8sato
fixup! feat(cli): add iroha transaction get and other important com…
6354c64 
…mands

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
Revert "ci: fix iroha_wasm_builder usage" (delegate to hyperledger-…
b15f419 
…iroha#5311)

This reverts commit bdff4af.

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato
chore: update CHANGELOG.md
a0b8b2f 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato dismissed stale reviews from mversic and aoyako via a0b8b2f February 12, 2025 15:21
@s8sato s8sato marked this pull request as ready for review February 12, 2025 15:27
@s8sato s8sato enabled auto-merge (squash) February 12, 2025 15:33
@s8sato s8sato mentioned this pull request Feb 12, 2025
Merged
@s8sato s8sato merged commit 623eb1f into hyperledger-iroha:main Feb 13, 2025
13 of 15 checks passed
@s8sato s8sato mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@aoyako aoyako aoyako approved these changes

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@mversic mversic

@s8sato s8sato

@aoyako aoyako

Labels
CLI Enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@s8sato @0x009922 @mversic @aoyako