Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local block file #491

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Remove local block file #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/api-engine/api/routes/node/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,7 @@ def block_file(self, request, pk=None):
for chunk in uploaded_block_file.chunks():
f.write(chunk)
join_peers(envs, block_path)
os.remove(block_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the removal, but should we retry the join_peers() once failed?

return Response(status=status.HTTP_202_ACCEPTED)
except Exception as e:
return Response(
Expand Down