Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(performance): parallel test execution #416 #648

Merged
merged 2 commits into from
Mar 11, 2021
Merged

fix(performance): parallel test execution #416 #648

merged 2 commits into from
Mar 11, 2021

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Mar 10, 2021 •
edited
Loading

Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes #416

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz
fix(performance): parallel test execution hyperledger-cacti#416
51b64ad 
Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes hyperledger-cacti#416

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz changed the title Fix 416 fix(performance): parallel test execution #416 Mar 10, 2021
@petermetz
refactor(ci): allow github action runners in parallel
2412b7e 
This should make it at least 4 times faster for the CI
to execute for any given pull request.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added Developer_Experience enhancement New feature or request Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. labels Mar 10, 2021
@petermetz petermetz marked this pull request as ready for review March 10, 2021 09:06
@petermetz petermetz enabled auto-merge (rebase) March 10, 2021 09:06
@petermetz petermetz disabled auto-merge March 11, 2021 17:55
@petermetz petermetz merged commit 28e24b1 into hyperledger-cacti:main Mar 11, 2021
@petermetz petermetz deleted the fix-416 branch March 11, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@jonathan-m-hamilton jonathan-m-hamilton Awaiting requested review from jonathan-m-hamilton

@kikoncuo kikoncuo Awaiting requested review from kikoncuo

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees
No one assigned
Labels
Developer_Experience enhancement New feature or request Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(performance): parallel test execution
2 participants
@petermetz @takeutak