feat(quorum): add prometheus exporter #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagpreetsinghsasan
requested review from
jonathan-m-hamilton and
petermetz
as code owners
petermetz
previously approved these changes
Feb 26, 2021
takeutak
reviewed
Mar 1, 2021
jagpreetsinghsasan
force-pushed
the
feature-534
branch
from
68b4cd6
to
9e0d621
Compare
takeutak
previously approved these changes
Mar 3, 2021
jagpreetsinghsasan
force-pushed
the
feature-534
branch
6 times, most recently
from
8be6aab
to
121db02
Compare
takeutak
previously approved these changes
Mar 15, 2021
jagpreetsinghsasan
force-pushed
the
feature-534
branch
from
121db02
to
fc5f9e3
Compare
petermetz
requested changes
Mar 17, 2021
jagpreetsinghsasan
force-pushed
the
feature-534
branch
from
fc5f9e3
to
596c2b9
Compare
petermetz
previously approved these changes
Mar 19, 2021
takeutak
previously approved these changes
Mar 23, 2021
jagpreetsinghsasan
dismissed stale reviews from takeutak and petermetz
via
858df34
jagpreetsinghsasan
force-pushed
the
feature-534
branch
from
596c2b9
to
858df34
Compare
takeutak
approved these changes
Mar 24, 2021
|
@jagpreetsinghsasan I recommend rebasing this to the PR that improves the GHA flakiness (and then also making sure to mark this as dependent on that) |
|
@jagpreetsinghsasan After rebasing to main the CI will hopefully pass and then this is ready to go |
petermetz
approved these changes
Mar 28, 2021
Primary Change -------------- 1. The quorum ledger connector plugin now includes the prometheus metrics exporter integration 2. OpenAPI spec now has api endpoint for the getting the prometheus metrics Refactorings that were also necessary to accomodate 1) and 2) ------------------------------------------------------------ 3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint 4. IPluginLedgerConnectorQuorumOptions interface in PluginLedgerConnectorQuorum class now has a prometheusExporter optional field 5. The PluginLedgerConnectorQuorum class has relevant functions and codes to incorporate prometheus exporter 6. Added Readme.md on the prometheus exporter usage Fixes hyperledger-cacti#534 Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(quorum): prometheus exporter metrics integration
Signed-off-by: Jagpreet Singh Sasan jagpreet.singh.sasan@accenture.com