test(cmd-api-server): jestify grpc-proto-gen-ts-client-healthcheck test #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
izuru0,
jagpreetsinghsasan,
VRamakrishna and
outSH
as code owners
outSH
requested changes
Oct 15, 2024
Comment on lines
91
to
101
| // await t.doesNotReject(responsePromise, "No error in healthcheck OK"); | ||
| // const res = await responsePromise; | ||
|
|
||
| // const resHc = res?.toObject(); | ||
|
|
||
| // t.ok(resHc, `healthcheck response truthy OK`); | ||
| // t.ok(resHc?.createdAt, `resHc.createdAt truthy OK`); | ||
| // t.ok(resHc?.memoryUsage, `resHc.memoryUsage truthy OK`); | ||
| // t.ok(resHc?.memoryUsage?.rss, `resHc.memoryUsage.rss truthy OK`); | ||
| // t.ok(resHc?.success, `resHc.success truthy OK`); | ||
| // t.end(); |
There was a problem hiding this comment.
Can this commented code be removed?
There was a problem hiding this comment.
@outSH Oops, thank you for catching that!
Edit: Removed the comments just now!
1. Also fixing a minor bug in config/config-service-example-config-validity.test.ts where the path of the temporary files generated by the test were being saved in the wrong directory instead of $PROJECT_ROOT/.tmp/... Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
test-cmd-api-server-migrate-to-jest-grpc-proto-gen-ts-client-healthcheck
branch
from
7ad630a
to
3411b82
Compare
jagpreetsinghsasan
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where the path of the temporary files generated by the test were being saved
in the wrong directory instead of $PROJECT_ROOT/.tmp/...
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.