Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor jest test negative test cases - phase 1 #3488

Conversation

ashnashahgrover
Copy link
Contributor

Commit to be reviewed

test: refactor jest test negative test cases - phase 1

Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes #3483

@ashnashahgrover
Copy link
Contributor Author

@jagpreetsinghsasan

Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?

@ashnashahgrover Yes please! It's looking good in general but we need to make sure the test assertions are working as intended (and if we found an underlying bug then first we have to fix those in order to be able to prove that the asesrtions themselves work as intended)

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only found one small things to fix

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@petermetz
Copy link
Contributor

Closing this due to inactivity, please feel free to re-open anytime if/when bandwidth is available to take it to the finish line (some of the checks are failing such as the linter)

@petermetz petermetz closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: refactor jest test negative test cases - phase 1
3 participants