Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cmd-api-server): migrate import from github test to Jest #3426

Conversation

petermetz
Copy link
Contributor

  1. Also two more test cases been migrated.
  2. A bug has been fixed in the test tooling package where the keychain vault
    container helper class was not passing in the publish all ports configuration
    option correctly. This would normally deserve it's own commit but this bug
    has been caught in other similar classes at least 3 times in the recent weeks
    so it's not really worth the attention anymore so I'll just include it in
    this commit so that we save some time on reviewer attention and CI resource
    usage.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Also two more test cases been migrated.
2. A  bug has been fixed in the test tooling package where the keychain vault
container helper class was not passing in the publish all ports configuration
option correctly. This would normally deserve it's own commit but this bug
has been caught in other similar classes at least 3 times in the recent weeks
so it's not really worth the attention anymore so I'll just include it in
this commit so that we save some time on reviewer attention and CI resource
usage.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the test-cmd-api-server-migrate-jest-plugin-import-github branch from a0fa032 to b6d48aa Compare July 24, 2024 21:02
@petermetz petermetz merged commit 03472aa into hyperledger-cacti:main Jul 24, 2024
143 of 144 checks passed
@petermetz petermetz deleted the test-cmd-api-server-migrate-jest-plugin-import-github branch July 24, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants