Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs/examples): add yarn patch to @ionic deps of example frontend #3378

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Jul 3, 2024

  1. The main field of the package.json of these two packages were invalid
    because the main field was set to bundle.js but that file is actually
    under ngx/bundle.js within the package directory and therefore the value
    of it originally was invalid that caused warnings in our tooling.
  2. By using the yarn patch feature we overcame this problem by modifying
    the sources of the dependencies in question: @ionic-native/splash-screen and
    @ionic-native/status-bar

Depends on lerna-lite/lerna-lite#887

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@github-actions github-actions bot removed the dependent label Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

This PR/issue depends on:

1. The `main` field of the package.json of these two packages were invalid
because the `main` field was set to `bundle.js` but that file is actually
under `ngx/bundle.js` within the package directory and therefore the value
of it originally was invalid that caused warnings in our tooling.
2. By using the yarn **patch** feature we overcame this problem by modifying
the sources of the dependencies in question: `@ionic-native/splash-screen` and
`@ionic-native/status-bar`

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the build-docs-examples-yarn-patch-ionic-pkg-main-field branch from 14d0bbe to f492a3b Compare July 6, 2024 02:13
@petermetz petermetz merged commit 02efca0 into hyperledger-cacti:main Jul 6, 2024
146 of 150 checks passed
@petermetz petermetz deleted the build-docs-examples-yarn-patch-ionic-pkg-main-field branch July 6, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants