test(cactus-core): fix false negative test results #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
outSH
approved these changes
Feb 7, 2024
The fix was to start statically importing the http helper library we use in `packages/cactus-core/src/main/typescript/web-services/handle-rest-endpoint-exception.ts` instead of how it was (dynamic imports at runtime). 1. There have been reports of dynamic imports causing segmentation faults in the NodeJS process when Jest is involved. 2. It is looking like this bug was another instance of that manifesting but slightly differently because this time around Jest decided to hide the stack trace of it as well. 3. Because of `2)` we have no specific evidence of the theory. We can only say that the change in this commit made the problem go away, but since there never was any crash logs or stack traces on the CI environment, this remains a conjecture. 4. Trying to reproduce the issue locally failed even when using the exact same versions of NodeJS and npm (and all the dependencies of course). 5. Based on `4)` it is likely that the segmentation fault is due to a race condition in the lower level (C/C++) code of NodeJS and/or Jest. Fixes hyperledger-cacti#2966 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2966
branch
from
3959cae
to
636c3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was to start statically importing the http helper library we use
in
packages/cactus-core/src/main/typescript/web-services/handle-rest-endpoint-exception.tsinstead of how it was (dynamic imports at runtime).
faults in the NodeJS process when Jest is involved.
but slightly differently because this time around Jest decided to hide
the stack trace of it as well.
2)we have no specific evidence of the theory. We can onlysay that the change in this commit made the problem go away, but since
there never was any crash logs or stack traces on the CI environment,
this remains a conjecture.
exact same versions of NodeJS and npm (and all the dependencies of course).
4)it is likely that the segmentation fault is due to arace condition in the lower level (C/C++) code of NodeJS and/or Jest.
Fixes #2966
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.