feat(indy-test-ledger): add helper class for indy ledger #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 11, 2023
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on hyperledger-cacti#2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
5 tasks
sandeepnRES
approved these changes
Dec 14, 2023
|
LGTM (not approving as Peter has already approved) |
|
This PR/issue depends on:
|
- Add `IndyTestLedger` class to setup test indy ledger for testing purposes. - Add functional tests for new test ledger class. - Minor fix in cleaning up sample indy test ledger. Peter's changes: 1. Rebased onto upstream/main as of 2024-01-21 which was a bit of a challenge on account of this being quite old (110 commits behind) 2. Meaning that there's a chance that I messed up some of the conflict resolutions in a way that is sub-optimal, please forgive if this is the case! Depends on hyperledger-cacti#2861 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
add_indy_testledger_class_pr
branch
from
ea8bee0
to
cca89dd
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jan 22, 2024
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on hyperledger-cacti#2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jan 23, 2024
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on hyperledger-cacti#2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jan 23, 2024
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on hyperledger-cacti#2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Jan 26, 2024
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on hyperledger-cacti#2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
that referenced
this pull request
Jan 26, 2024
- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
of plain aries agent.
Depends on #2946
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndyTestLedgerclass to setup test indy ledger for testing purposes.Depends on #2861
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.