feat(cactus-plugin-ledger-connector-fabric): support delegated (offline) signatures #2644

outSH · 2023-08-29T10:46:15Z

Add new RunDelegatedSignTransactionEndpointV1 endpoint for delegated / offline signing.
Takes signerCertificate and signerMspID, uses signCallback on connector to sign messages.
Sign must be implemented by a user, can contain any logic
(contacting 3'rd party services, reading from secure sources, etc…).
Interface is similar to transact. Supports private transactions.
Refactor transact endpoint: Use common logic for handling response format. with delegated transact
Refactor logic of choosing ednorsers in transact endpoint. Previously both endorsingPeers
and endorsingParties were selecting organizations in sligly different way under different
circumstances. Now endorsingPeers selectes peers and endorsingOrgs selects orgs for all
cases (query, send, privatesend) in both transact and transact with delegated sign.
This is more consistent and predictable.
Add new socketio endpoint SubscribeDelegatedSign for monitoring new blocks with delegated sign.
Use common error handling in getblock, transact and transact delgated endpoints.
Add functional tests for delegated signing feature.

Depends on #2598

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

…ocketio connector - Remove cactus-plugin-ledger-connector-fabric-socketio connector. - Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio. Sample app will use delegated signing, similar to offline signing in old connector. - Remove dead code from cmd-socketio-server - Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary. Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests). It can be updated in separate PR later on. Depends on: hyperledger-cacti#2644 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

packages/cactus-plugin-ledger-connector-fabric/src/main/json/openapi.json

github-actions · 2023-09-18T11:43:22Z

This PR/issue depends on:

~~hyperledger/cacti#2598~~
By Dependent Issues (🤖). Happy coding!

outSH · 2023-09-19T12:43:13Z

@petermetz I'm afraid the VM is running out of space after I've added new tests, any suggestions how we can fix this? :)

See messages before failing tests:

2023-09-18T12:32:09.4642674Z ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 40 MB

2023-09-18T13:32:01.0022613Z [2023-09-18T13:32:00.902Z] DEBUG (FabricTestLedgerV1): [ghcr.io/hyperledger/cactus-fabric2-all-in-one:2023-08-17-issue2057-pr2135] 'time="2023-09-18T13:32:00.900994274Z" level=error msg="Error writing log message" driver=json-file error="error writing log entry: write /var/lib/docker/containers/91c20802ab2f186b640da0a53d461b665ab24d386f4a9d284eb308686f7f06dd/91c20802ab2f186b640da0a53d461b665ab24d386f4a9d284eb308686f7f06dd-json.log: no space left on device" message=\r\n'

Test affected: plugin-ledger-connector-fabric-0

(btw need to fix cactus-cmd-api-server test as well before merge)

…ocketio connector - Remove cactus-plugin-ledger-connector-fabric-socketio connector. - Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio. Sample app will use delegated signing, similar to offline signing in old connector. - Remove dead code from cmd-socketio-server - Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary. Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests). It can be updated in separate PR later on. Depends on: hyperledger-cacti#2644 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

petermetz · 2023-09-28T18:55:44Z

@petermetz I'm afraid the VM is running out of space after I've added new tests, any suggestions how we can fix this? :)

See messages before failing tests:

2023-09-18T12:32:09.4642674Z ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 40 MB

2023-09-18T13:32:01.0022613Z [2023-09-18T13:32:00.902Z] DEBUG (FabricTestLedgerV1): [ghcr.io/hyperledger/cactus-fabric2-all-in-one:2023-08-17-issue2057-pr2135] 'time="2023-09-18T13:32:00.900994274Z" level=error msg="Error writing log message" driver=json-file error="error writing log entry: write /var/lib/docker/containers/91c20802ab2f186b640da0a53d461b665ab24d386f4a9d284eb308686f7f06dd/91c20802ab2f186b640da0a53d461b665ab24d386f4a9d284eb308686f7f06dd-json.log: no space left on device" message=\r\n'

Test affected: plugin-ledger-connector-fabric-0

(btw need to fix cactus-cmd-api-server test as well before merge)

@outSH Set the env var FREE_UP_GITHUB_RUNNER_DISK_SPACE_DISABLED to false in the job's environment variables and that will free up about 20 gigs of space. This used to be the default for the CI script but it takes minutes to complete so now we only turn it on when necessary.

petermetz

@outSH LGTM, thank you!

izuru0

LGTM

…ne) signatures - Add new `RunDelegatedSignTransactionEndpointV1` endpoint for delegated / offline signing. Takes `signerCertificate` and `signerMspID`, uses `signCallback` on connector to sign messages. Sign must be implemented by a user, can contain any logic (contacting 3'rd party services, reading from secure sources, etc…). Interface is similar to transact. Supports private transactions. - Refactor transact endpoint: Use common logic for handling response format. with delegated transact - Refactor logic of choosing ednorsers in transact endpoint. Previously both `endorsingPeers` and `endorsingParties` were selecting organizations in sligly different way under different circumstances. Now `endorsingPeers` selectes peers and `endorsingOrgs` selects orgs for all cases (query, send, privatesend) in both transact and transact with delegated sign. This is more consistent and predictable. - Add new socketio endpoint `SubscribeDelegatedSign` for monitoring new blocks with delegated sign. - Use common error handling in getblock, transact and transact delgated endpoints. - Add functional tests for delegated signing feature. Depends on: hyperledger-cacti#2598 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

…ocketio connector - Remove cactus-plugin-ledger-connector-fabric-socketio connector. - Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio. Sample app will use delegated signing, similar to offline signing in old connector. - Remove dead code from cmd-socketio-server - Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary. Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests). It can be updated in separate PR later on. Depends on: hyperledger-cacti#2644 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

…ocketio connector - Remove cactus-plugin-ledger-connector-fabric-socketio connector. - Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio. Sample app will use delegated signing, similar to offline signing in old connector. - Remove dead code from cmd-socketio-server - Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary. Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests). It can be updated in separate PR later on. Depends on: #2644 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

…ocketio connector - Remove cactus-plugin-ledger-connector-fabric-socketio connector. - Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio. Sample app will use delegated signing, similar to offline signing in old connector. - Remove dead code from cmd-socketio-server - Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary. Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests). It can be updated in separate PR later on. Depends on: hyperledger-cacti#2644 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

outSH requested review from petermetz, takeutak, izuru0, jagpreetsinghsasan, VRamakrishna and sandeepnRES as code owners August 29, 2023 10:46

outSH force-pushed the fabric_delegated_sign_pr branch from 216bd93 to 4687000 Compare August 29, 2023 12:28

outSH mentioned this pull request Aug 29, 2023

feat(cactus-plugin-ledger-connector-fabric-socketio): remove fabric-socketio connector #2645

Merged

outSH force-pushed the fabric_delegated_sign_pr branch 2 times, most recently from 2952221 to b95183c Compare August 29, 2023 14:23

petermetz reviewed Aug 29, 2023

View reviewed changes

packages/cactus-plugin-ledger-connector-fabric/src/main/json/openapi.json Show resolved Hide resolved

github-actions bot added the dependent label Sep 11, 2023

outSH force-pushed the fabric_delegated_sign_pr branch from b95183c to 4ee177e Compare September 18, 2023 11:39

github-actions bot removed the dependent label Sep 18, 2023

outSH requested a review from petermetz September 19, 2023 12:52

petermetz approved these changes Sep 28, 2023

View reviewed changes

outSH force-pushed the fabric_delegated_sign_pr branch from 4ee177e to 7425946 Compare October 2, 2023 09:11

izuru0 approved these changes Oct 10, 2023

View reviewed changes

petermetz enabled auto-merge (rebase) October 10, 2023 18:08

petermetz force-pushed the fabric_delegated_sign_pr branch from 7425946 to b1718fe Compare October 10, 2023 18:08

petermetz merged commit e2812f4 into hyperledger-cacti:main Oct 10, 2023
46 of 63 checks passed

petermetz mentioned this pull request Jun 14, 2024

chore(release): publish v2.0.0-rc.1 #3324

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cactus-plugin-ledger-connector-fabric): support delegated (offline) signatures #2644

feat(cactus-plugin-ledger-connector-fabric): support delegated (offline) signatures #2644

outSH commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Sep 18, 2023

outSH commented Sep 19, 2023 •

edited

Loading

petermetz commented Sep 28, 2023

petermetz left a comment

izuru0 left a comment

feat(cactus-plugin-ledger-connector-fabric): support delegated (offline) signatures #2644

feat(cactus-plugin-ledger-connector-fabric): support delegated (offline) signatures #2644

Conversation

outSH commented Aug 29, 2023 • edited Loading

github-actions bot commented Sep 18, 2023

outSH commented Sep 19, 2023 • edited Loading

petermetz commented Sep 28, 2023

petermetz left a comment

Choose a reason for hiding this comment

izuru0 left a comment

Choose a reason for hiding this comment

outSH commented Aug 29, 2023 •

edited

Loading

outSH commented Sep 19, 2023 •

edited

Loading