test: fix path of and name of RIFUtil.test.ts #1515 #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnabnandikgp
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
force-pushed
the
test/fix-path-and-name
branch
from
eaecf14
to
691f634
Compare
petermetz
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
@arnabnandikgp Thank you! Sorry but I made a mistake when creating the original issue, I meant to say kebab-case not camelCase. I fixed the problem myself and pushed it onto your PR branch so with this change in it now it's LGTM. Thanks again!
takeutak
approved these changes
Jun 15, 2023
Peter: Also modified the import path based on the location of the test file now being different. Fixes hyperledger-cacti#1515 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Arnab Nandi <arnabnandi2002@gmail.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
test/fix-path-and-name
branch
from
691f634
to
59946f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed name of
RIFUtil.test.tstorifUtil.test.tsand moved the file to unit test directory.fixes: #1515
Signed-off-by: Arnab Nandi arnabnandi2002@gmail.com